Remove @JsonIgnore annotations for private members of TaskAction …

…classes (apache#16099) * Remove @JsonIgnore annotations for private members * checkstyle fix - removed unused imports.
monetate · Mar 11, 2024 · 8084f22 · 8084f22
1 parent 94d2a28
commit 8084f22
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 38 deletions.
diff --git a/...ing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java b/...ing-service/src/main/java/org/apache/druid/indexing/common/actions/LockReleaseAction.java
@@ -20,15 +20,13 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import org.apache.druid.indexing.common.task.Task;
 import org.joda.time.Interval;
 
 public class LockReleaseAction implements TaskAction<Void>
 {
-  @JsonIgnore
   private final Interval interval;
 
   @JsonCreator

diff --git a/...ce/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java b/...ce/src/main/java/org/apache/druid/indexing/common/actions/MarkSegmentsAsUnusedAction.java
@@ -20,18 +20,14 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import org.apache.druid.indexing.common.task.Task;
 import org.joda.time.Interval;
 
 public class MarkSegmentsAsUnusedAction implements TaskAction<Integer>
 {
-  @JsonIgnore
   private final String dataSource;
-
-  @JsonIgnore
   private final Interval interval;
 
   @JsonCreator

diff --git a/.../src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java b/.../src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import org.apache.druid.indexing.common.task.Task;
@@ -34,16 +33,9 @@
 
 public class RetrieveUnusedSegmentsAction implements TaskAction<List<DataSegment>>
 {
-  @JsonIgnore
   private final String dataSource;
-
-  @JsonIgnore
   private final Interval interval;
-
-  @JsonIgnore
   private final Integer limit;
-
-  @JsonIgnore
   private final DateTime maxUsedStatusLastUpdatedTime;
 
   @JsonCreator

diff --git a/...ce/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java b/...ce/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUsedSegmentsAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.base.Preconditions;
@@ -67,13 +66,8 @@ public class RetrieveUsedSegmentsAction implements TaskAction<Collection<DataSeg
 {
   private static final Logger log = new Logger(RetrieveUsedSegmentsAction.class);
 
-  @JsonIgnore
   private final String dataSource;
-
-  @JsonIgnore
   private final List<Interval> intervals;
-
-  @JsonIgnore
   private final Segments visibility;
 
   @JsonCreator

diff --git a/...e/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java b/...e/src/main/java/org/apache/druid/indexing/common/actions/SegmentMetadataUpdateAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.collect.ImmutableSet;
@@ -38,7 +37,6 @@
 
 public class SegmentMetadataUpdateAction implements TaskAction<Void>
 {
-  @JsonIgnore
   private final Set<DataSegment> segments;
 
   @JsonCreator

diff --git a/...ing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java b/...ing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentNukeAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.collect.ImmutableSet;
@@ -38,7 +37,6 @@
 
 public class SegmentNukeAction implements TaskAction<Void>
 {
-  @JsonIgnore
   private final Set<DataSegment> segments;
 
   @JsonCreator

diff --git a/...ce/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java b/...ce/src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockAcquireAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.base.Preconditions;
@@ -41,11 +40,7 @@
 public class TimeChunkLockAcquireAction implements TaskAction<TaskLock>
 {
   private final TaskLockType type;
-
-  @JsonIgnore
   private final Interval interval;
-
-  @JsonIgnore
   private final long timeoutMs;
 
   @JsonCreator

diff --git a/...src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java b/...src/main/java/org/apache/druid/indexing/common/actions/TimeChunkLockTryAcquireAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import org.apache.druid.indexing.common.TaskLock;
@@ -38,10 +37,7 @@
  */
 public class TimeChunkLockTryAcquireAction implements TaskAction<TaskLock>
 {
-  @JsonIgnore
   private final TaskLockType type;
-
-  @JsonIgnore
   private final Interval interval;
 
   @JsonCreator

diff --git a/...-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java b/...-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateLocationAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.base.Optional;
@@ -30,7 +29,6 @@
 
 public class UpdateLocationAction implements TaskAction<Void>
 {
-  @JsonIgnore
   private final TaskLocation taskLocation;
 
   @JsonCreator

diff --git a/...ng-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java b/...ng-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java
@@ -20,7 +20,6 @@
 package org.apache.druid.indexing.common.actions;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.google.common.base.Optional;
@@ -32,9 +31,7 @@
 
 public class UpdateStatusAction implements TaskAction<Void>
 {
-  @JsonIgnore
   private final String status;
-  @JsonIgnore
   private final TaskStatus statusFull;
 
   @Deprecated