-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebranding & Update Permissions #8
base: main
Are you sure you want to change the base?
Conversation
umisora
commented
Aug 22, 2023
- IT-Management Cloud Service had changed the productname to Admina.
- Update IAM Permission List
- Support ReadOnly Permissions
|
https://registry.terraform.io/namespaces/moneyforward-i Once we switch the reference to the new module, the old module will be removed from the Terraform Registry. |
"iam:DeleteLoginProfile", | ||
"iam:ListAttachedUserPolicies", | ||
"iam:DetachUserPolicy", | ||
"iam:CreateUser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit strange, other permissions are read/delete related, is this for provisioning? But we can't attach anything to the user 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narxeba Can you confirm it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is for provisioning.
But we can't attach anything to the user 🤔
Hmm, I see. Let me check the current implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narxeba How about this ? I would like to proceed this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umisora So right now our provisioning for IAM can only add a new user without any roles, permissions :wwww: You can process this PR. I'll work on improving provisioning for IAM later