Add support join extra conditions #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MongoDB uses ObjectId rather than integer
WaVEV
force-pushed
the
add-support-join-extra-conditions
branch
from
2095bf4
to
e4e3c60
Compare
timgraham
force-pushed
the
mongodb-5.0.x
branch
from
a586021
to
5552927
Compare
MongoDB uses ObjectId rather than integer
timgraham
force-pushed
the
mongodb-5.0.x
branch
from
2995f4b
to
bccf63b
Compare
timgraham
reviewed
Sep 24, 2024
tests/generic_relations/tests.py
Outdated
| Animal.objects.exclude(tags__tag="fatty"), | ||
| [self.lion], | ||
| ) | ||
| # Exists is not supported in MongoDB |
There was a problem hiding this comment.
I added this change to the fork. I think that's all this branch requires, but let me know.
There was a problem hiding this comment.
Indeed, if we aren't using objectIdField we just need to modify this test only.
WaVEV
force-pushed
the
add-support-join-extra-conditions
branch
from
e4e3c60
to
ee622f9
Compare
timgraham
force-pushed
the
mongodb-5.0.x
branch
3 times, most recently
from
5deea06
to
353d6b7
Compare
timgraham
force-pushed
the
mongodb-5.0.x
branch
4 times, most recently
from
03b9901
to
5a247e8
Compare
|
Changes merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change IntegerField to ObjectIdField