BAAS-26308: Add StringifyError to Exception struct #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnicodeSnowman
approved these changes
Dec 6, 2023
runtime_test.go
Outdated
|
|
||
| return testObject | ||
| }, | ||
| expectedString: "{\"foo\":\"bar\",\"fizz\":\"buzz\"}", |
There was a problem hiding this comment.
[q] are goja objects always ordered? just want to make sure the keys in this string will always be in the same order.
There was a problem hiding this comment.
I am looking to see if I can figure this out definitively. Anecdotally, I ran the tests with -count=30 and did not see any changes in the order.
There was a problem hiding this comment.
It uses a go map under the hood, whose iteration order is not guaranteed. I think I will try to update this. Probably just going to break it into a separate test and get a little clever with the string comparison.
There was a problem hiding this comment.
Got a new test up there, let me know what you think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.