Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAAS-22176: add mem usage estimation for map objects #120

Merged
merged 4 commits into from
Jun 12, 2024
Merged

BAAS-22176: add mem usage estimation for map objects #120

merged 4 commits into from
Jun 12, 2024

Conversation

Gabri3l
Copy link

@Gabri3l Gabri3l commented Jun 10, 2024

As a drive-by I defined a sample rate that is easier to manage across all estimates, I think eventually we could pass it as a param to make our tests simpler.

nickpoindexter
nickpoindexter reviewed Jun 11, 2024
View reviewed changes
array.go Outdated Show resolved Hide resolved
builtin_map.go Outdated Show resolved Hide resolved
mem_context.go Outdated Show resolved Hide resolved
kpatel71716
kpatel71716 approved these changes Jun 11, 2024
View reviewed changes
Copy link

@kpatel71716 kpatel71716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nothing from outside of Nick's comments. Interested to see the impact, if any, of 20% sampling but I'm down to go to 20

@Gabri3l
Copy link
Author

Gabri3l commented Jun 11, 2024

Sorry I introduced a bunch of changes but the commits should help review this, it's mostly a refactoring for the changes in mem_context.go, I realized I'd rather be able to set the sample rate from baas instead of having to make changes here every time.

nickpoindexter
nickpoindexter approved these changes Jun 11, 2024
View reviewed changes
Copy link

@nickpoindexter nickpoindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some test cleanup

mem_context.go Show resolved Hide resolved
memory_test.go Outdated Show resolved Hide resolved
memory_test.go Outdated Show resolved Hide resolved
@Gabri3l Gabri3l merged commit cb620be into mongodb-forks:realm Jun 12, 2024
2 of 6 checks passed
@Gabri3l Gabri3l deleted the BAAS-22176 branch June 12, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpoindexter nickpoindexter nickpoindexter approved these changes

@kpatel71716 kpatel71716 Awaiting requested review from kpatel71716

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabri3l @kpatel71716 @nickpoindexter