BAAS-11692: add mem usage for setObject and func objects #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builtin_set.go
Outdated
|
|
||
| // We can use samplesVisited instead of an index since we iterate using | ||
| // iterNext | ||
| for item := so.m.iterFirst; item != nil && samplesVisited < uint64(totalItems); item = item.iterNext { |
There was a problem hiding this comment.
[q] looks like totalItems is the size of the map but we only increment sampleVisited when its divisible by the sample size which means this case should never be true samplesVisited < uint64(totalItems) (unless you are accounting for size of 1?). Can we remove that check samplesVisited < uint64(totalItems):
for item := so.m.iterFirst; item != nil; item = item.iterNext {
There was a problem hiding this comment.
you're right, even with a step of 1 we would have a nil item and get out I believe so this is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.