You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
[q] could we could make a v2 tag from the realm branch? Or is the intention to start versioning each of the individual packages for more granular versioning?
Not opposed to either approach, just curious. If we are going with the latter, this lgtm
[q] could we could make a v2 tag from the realm branch? Or is the intention to start versioning each of the individual packages for more granular versioning?
Not opposed to either approach, just curious. If we are going with the latter, this lgtm
Still doing the tags, IIUC you gotta do this for major versions in go. From baas I can't just use v2.0.0 I have to use goja/v2 v2.0.0 which is why this PR is needed. We can still go back ahah
Still doing the tags, IIUC you gotta do this for major versions in go. From baas I can't just use v2.0.0 I have to use goja/v2 v2.0.0 which is why this PR is needed. We can still go back ahah
Won't do, I don't think this is worth it every time we make a breaking change to the mem usage. It might also conflict with an eventual v2 of goja and make things confusing.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.