BAAS-32009: add defer to all ctx.Ascend() calls in realm #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabri3l
requested changes
Jun 27, 2024
Gabri3l
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Congratulations on your first contribution to our fork of Goja!
You might see some tasks fail, that's OK and nothing we care about. As long as the test suite works here, we are good to go.
Remember to "Squash and Merge", saying this because the preference on merging strategy might not stay across different repos (I made that mistake before due to muscle memory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.