BAAS-22402: add early exits when possible memusage #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpoindexter
commented
Jul 27, 2023
| @@ -25,7 +25,11 @@ tasks: | |||
| export PATH=$ROOT_DIR/go/bin:$PATH | |||
|
|
|||
| cd goja | |||
| go test -v ./... | |||
| go test -v ./... >> ${workdir}/goja.suite | |||
| - command: gotest.parse_files | |||
There was a problem hiding this comment.
[drive-by] to get tests under tests tab in EVG
fix tests after removing early exit from objects fix more tests
nickpoindexter
force-pushed
the
BAAS-22402
branch
from
854ef8f
to
c4a8d72
Compare
Gabri3l
requested changes
Jul 28, 2023
Co-authored-by: Taylor Cannon <[email protected]>
arahmanan
reviewed
Jul 31, 2023
mem_context.go
Outdated
| // MemUsageLimitExceeded ensures a limit function is defined and checks against the limit. If limit is breached | ||
| // it will return true, if the limit check is undefined it will return an error | ||
| func (m *MemUsageContext) MemUsageLimitExceeded(memUsage uint64) (bool, error) { | ||
| if m.MemUsageExceedsLimit == nil { |
There was a problem hiding this comment.
do we need to perform this check in tight loops? I would rather not if possible. Wouldn't we be able to check this in advance?
There was a problem hiding this comment.
The var is an exported pointer structure so anyone could change it at any point. I think if we determined that the only ever definition of this function would be:
if memUsage > m.MemLimit {
return err
}then we can remove these checks and clean things up a bit. Happy to do so if everyone is on board.
There was a problem hiding this comment.
Chatted with @Gabri3l offline and he was fine with moving forward this approach as long as the limit field was not exported. It has been refactored.
remove limitfunction error
nickpoindexter
force-pushed
the
BAAS-22402
branch
from
92ff8ee
to
944cf27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR it seems like we have opportunity to exit large arrays early when we've exceeded the total mem allowed. This does not cause the interrupt in the function and will continue to rely on the poller within pass to check these values but should ease the CPU needed to calculate mem.
I think this also allows us to remove the estimate, but that path is a bit different so was not adjusted as part of this effort.