BAAS-23857: apply new mem usage everyhere but objectGoSlice and objectGoMapSimple #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this so that the memory usage is now correct and the new memory usage has the only difference of accounting for objectGoSlice and objectGoMapSimple. This will help us differentiate the contribution and diff of these new memory changes.
I expect moving forward for the process to be similar to this, once the memory changes are in production and we are good, we can promote them in goja as well so that any new memory change can be tracked independently.
Estimates and early exit for objectGoSlice and objectGoMapSimple are part of a follow-up ticket.