Address remaining comments

mongodb-forks · Jul 28, 2023 · 5eb5f9d · 5eb5f9d
1 parent 021623c
commit 5eb5f9d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/checker/check-request-property-min-updated.go b/checker/check-request-property-min-updated.go
@@ -64,11 +64,12 @@ func RequestPropertyMinIncreasedCheck(diffReport *diff.Diff, operationsSources *
 							minDiff.To == nil {
 							return
 						}
-						level := ERR
-						if propertyDiff.Revision.Value.ReadOnly {
-							level = INFO
-						}
 						if IsIncreasedValue(minDiff) {
+							level := ERR
+							if propertyDiff.Revision.Value.ReadOnly {
+								level = INFO
+							}
+
 							result = append(result, ApiChange{
 								Id:          "request-property-min-increased",
 								Level:       level,

diff --git a/checker/check-request-property-min-updated_test.go b/checker/check-request-property-min-updated_test.go
@@ -45,7 +45,7 @@ func TestRequestPropertyMinDecreasedCheck(t *testing.T) {
 	require.Len(t, errs, 1)
 	require.Equal(t, checker.ApiChange{
 		Id:          "request-property-min-decreased",
-		Text:        "the 'age' request property's min was decreased to '10.00'",
+		Text:        "the 'age' request property's min was decreased from '15.00' to '10.00'",
 		Level:       checker.INFO,
 		Operation:   "POST",
 		Path:        "/pets",

diff --git a/checker/localizations/localizations.go b/checker/localizations/localizations.go