add dbshell tests to CI #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
commented
Oct 22, 2024
.github/workflows/test-python.yml
Outdated
| @@ -31,7 +31,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| repository: 'mongodb-forks/django' | |||
| ref: 'mongodb-5.0.x' | |||
| ref: 'mongodb-tests1' | |||
There was a problem hiding this comment.
.github/workflows/test-python.yml
Outdated
| @@ -62,6 +62,7 @@ jobs: | |||
| dates | |||
| datetimes | |||
| db_functions | |||
| dbshell1 | |||
There was a problem hiding this comment.
When we'd like to use the same app name as Django (when tests in this repo are modeled off tests there), I haven't thought of a better way to differentiate than add something like "1". We could add something longer like "_mongo" but it's just more to type.
WaVEV
approved these changes
Oct 23, 2024
timgraham
force-pushed
the
move-db-shell-tests
branch
from
5a89366
to
17d8a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were previously in the Django fork, but mongodb-forks/django#9 allows putting tests in this repo.