Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelogs for 2.3.5, 2.3.6, 2.3.7 #373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdb-ashley
Copy link
Collaborator

@mdb-ashley mdb-ashley commented Dec 19, 2024

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for docs-mongodb-shell ready!

Name Link
🔨 Latest commit 50e5590
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongodb-shell/deploys/67646a27dbf9b80008c27589
😎 Deploy Preview https://deploy-preview-373--docs-mongodb-shell.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these in this consolidated issue, @mdb-ashley! This one LGTM.

Thanks,
Joe

Bug Fixes:

- :issue:`MONGOSH-1943` - Only ever run ``MongoshRepl.onExit`` once
- :issue:`MONGOSH-1969` - Don't override output that came from onPrint
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter item is an internal ticket for an issue in 2.3.6 that users will never see (it's only showing in Compass's built-in REPL). I'd drop it:

Suggested change
- :issue:`MONGOSH-1969` - Don't override output that came from onPrint


Bug Fixes:

- :issue:`MONGOSH-1943` - Only ever run ``MongoshRepl.onExit`` once
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- :issue:`MONGOSH-1943` - Only ever run ``MongoshRepl.onExit`` once
- :issue:`MONGOSH-1943` - Fix cause of rare flaky "Mongosh not initialized yet" errors

This is how this would show up to users, I don't think the raw commit title helps users understand what's going on here

Comment on lines +33 to +40
Bug Fixes:

- :issue:`MONGOSH-1943` - Account for possibility of process.exit() throwing
under coverage; Improve debuggability of ``mongosh not initialized yet`` errors
- :issue:`COMPASS-8576` - Keep operation in progress while switching tabs

`Full release notes available on JIRA
<https://jira.mongodb.org/browse/MONGOSH-1922?jql=project%20%3D%20MONGOSH%20AND%20fixVersion%20%3D%202.3.6>`__.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the release notes ticket says, this is really a fully internal release. None of these changes are user-facing, and I'd say as much here.

Suggested change
Bug Fixes:
- :issue:`MONGOSH-1943` - Account for possibility of process.exit() throwing
under coverage; Improve debuggability of ``mongosh not initialized yet`` errors
- :issue:`COMPASS-8576` - Keep operation in progress while switching tabs
`Full release notes available on JIRA
<https://jira.mongodb.org/browse/MONGOSH-1922?jql=project%20%3D%20MONGOSH%20AND%20fixVersion%20%3D%202.3.6>`__.
Contains internal enhancements and improvements.
`Full release notes available on JIRA
<https://jira.mongodb.org/browse/MONGOSH-1922?jql=project%20%3D%20MONGOSH%20AND%20fixVersion%20%3D%202.3.6>`__.

(This is taken from the phrasing we use for other releases of this type)

- :issue:`MONGOSH-1935` - Retry connection without system certificates in case
of TLS errors
- :issue:`MONGOSH-1632` - Add Node.js patch for OpenSSL Windows build fix
- :issue:`MONGOSH-1924` - Increase timeouts for AWS tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- :issue:`MONGOSH-1924` - Increase timeouts for AWS tests

This only affects internal mongosh development, not usage of mongosh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants