PHPC-936: Define PHP_MONGODB_VERSION and STABILITY constants #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the redundant MONGODB_VERSION constant renames the existing version and stability constants to be consistent with the format in PHP's extension skeleton: php/php-src@dcfd753
jmikola
commented
Mar 17, 2017
| #define MONGODB_STABILITY_S "devel" | ||
| #define MONGODB_VERSION MONGODB_VERSION_S | ||
| #define PHP_MONGODB_VERSION "1.2.8-dev" | ||
| #define PHP_MONGODB_STABILITY "devel" |
There was a problem hiding this comment.
Arguments of the extension skeleton aside, these names are also more consistent with the MONGODB_VERSION and MONGODB_STABILITY constants we define for userland.
As for MONGODB_VERSION, I found no references to it apart from zend_module_entry. This seemed ripe for removal after updated the struct to use PHP_MONGODB_VERSION.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-936
This removes the redundant MONGODB_VERSION constant renames the existing version and stability constants to be consistent with the format in PHP's extension skeleton: php/php-src@dcfd753
Fixes: #562