CLOUDP-269300: Bump to Go 1.23 #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roothorp
requested review from
helderjs,
s-urbaniak,
josvazg,
igor-karpukhin and
cveticm
|
@roothorp I would make this a draft until we figure out the licenses issue. BTW, I can take this PR if you want. |
|
Taking this from @roothorp will make it a draft while I figure out the licenses issue |
josvazg
force-pushed
the
CLOUDP-269300-go-1.23
branch
from
edb93f6
to
fb21100
Compare
josvazg
reviewed
Sep 30, 2024
Comment on lines
+130
to
+132
| export GOOS=linux | ||
| export GOARCH=amd64 | ||
| go run github.com/google/$(GO_LICENSES)@v$(GO_LICENSES_VERSION) csv --include_tests $(BASE_GO_PACKAGE)/... > licenses.csv |
There was a problem hiding this comment.
Not the prettiest fix, but the only one I could find.
From here:
google/go-licenses#149 (comment)
Seems we won't be able to use devbox/nix for the go-licenses binary and instead need to use it as a module dep.
cc @roothorp
josvazg
approved these changes
Sep 30, 2024
s-urbaniak
reviewed
Oct 1, 2024
s-urbaniak
reviewed
Oct 1, 2024
s-urbaniak
reviewed
Oct 1, 2024
s-urbaniak
requested changes
Oct 1, 2024
Fixes applied |
Use %w for error wrapping Co-authored-by: Sergiusz Urbaniak <[email protected]> Signed-off-by: jose.vazquez <[email protected]>
josvazg
force-pushed
the
CLOUDP-269300-go-1.23
branch
from
a8c6a16
to
30cc42b
Compare
|
Actually @s-urbaniak , we need to roll that last fix back: pkg/controller/atlasproject/custom_roles.go:203:28: printf: fmt.Errorf format %w has arg stat.Error of wrong type string (govet)
err = errors.Join(err, fmt.Errorf("%w", stat.Error))stat.Error is not an |
josvazg
reviewed
Oct 1, 2024
josvazg
reviewed
Oct 1, 2024
josvazg
reviewed
Oct 1, 2024
Revert to use `%s` again, because `stat.Error` is a `string` and thus cannot be wrapped as an error.
s-urbaniak
approved these changes
Oct 1, 2024
helderjs
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the relevant golangci version bump to support Go 1.23.
Also includes other miscellaneous version updates for devbox (these will be automated similar to dependabot in future).
wrt
exportloopref:All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).