Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Mongoid to version 9.0.0 #245

Merged
merged 6 commits into from
May 12, 2024
Merged

Upgrade Mongoid to version 9.0.0 #245

merged 6 commits into from
May 12, 2024

Conversation

sairamsrinivasan
Copy link
Collaborator

This PR upgrades mongoid to version 9.0.0

sairamsrinivasan
sairamsrinivasan commented May 11, 2024
View reviewed changes
spec/models/profile.rb
@@ -6,7 +6,7 @@ class Profile
field :age
field :hobbies, type: Array, default: []

embedded_in :user, inverse_of: :profile
embedded_in :user, inverse_of: :profile, touch: false
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embedded associations now have the touch option defaulted to true: https://www.mongodb.com/docs/mongoid/master/release-notes/mongoid-9.0/#embedded_in-associations-now-default-to-touch--true

@sairamsrinivasan sairamsrinivasan marked this pull request as ready for review May 11, 2024 22:09
@sairamsrinivasan
Copy link
Collaborator Author

Ready for review.

@dangerpr-bot
Copy link

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

dblock
dblock requested changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to CI please?

https://github.com/mongoid/mongoid-rspec/blob/master/.github/workflows/rspec.yml#L17

@sairamsrinivasan
Copy link
Collaborator Author

@dblock - I appreciate the review. Please check out the latest revisions.

dblock
dblock requested changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit, apologies for my OCD, looking good.

CHANGELOG.md Outdated Show resolved Hide resolved
@sairamsrinivasan
Copy link
Collaborator Author

One more nit, apologies for my OCD, looking good.

No worries. Thanks for being thorough. I pushed an update.

This is unrelated but any chance that you or the other maintainers can look at my other PR: #246? I will likely need to rebase this.

dblock
dblock approved these changes May 12, 2024
View reviewed changes
CHANGELOG.md
@@ -1,7 +1,8 @@
### 4.1.1 (Next)
### 4.2.0 (Next)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mongoid/mongoid-rspec/blob/master/lib/mongoid/rspec/version.rb also needs to be incremented. Can be done in your next PR.

@dblock
Copy link
Collaborator

dblock commented May 12, 2024

This is unrelated but any chance that you or the other maintainers can look at my other PR: #246? I will likely need to rebase this.

Yes, I was doing this one first. Rebase and I'll take a look.

@dblock dblock merged commit f55e0f9 into mongoid:master May 12, 2024
11 checks passed
@dblock dblock mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sairamsrinivasan @dangerpr-bot @dblock