Additional specs for embedded doc move

spec/integration/embedded_spec.rb

@@ -12,40 +12,180 @@
     end
 
     def positions
-      EmbedsOrderable.order_by(position: 1).all.map { |eo| eo.embedded_orderables.map(&:position).sort }
+      EmbedsOrderable.order_by(position: 1).all.map { |eo| eo.embedded_orderables.map(&:position) }
     end
 
     it 'sets proper position while creation' do
       expect(positions).to eq([[1, 2], [1, 2, 3]])
     end
 
-    it 'move_to! moves an item returned by a query to position' do
-      parent = EmbedsOrderable.first
-      child1 = parent.embedded_orderables.where(position: 1).first
-      child2 = parent.embedded_orderables.where(position: 2).first
-      child1.move_to!(2)
-      expect(child1.reload.position).to eq(2)
-      expect(child2.reload.position).to eq(1)
+    context '#move_to!' do
+      it 'moves an embedded item to top position' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child2.move_to!(1)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
+
+      it 'moves an embedded item to top position by symbol' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child2.move_to!(:top)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
+
+      it 'moves an embedded item above top position' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child2.move_to!(0)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
+
+      it 'moves an embedded item to middle position' do
+        parent = EmbedsOrderable.last
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child3 = parent.embedded_orderables.where(position: 3).first
+        child3.move_to!(2)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([1, 3, 2])
+        expect(child1.position).to eq(1)
+        expect(child2.position).to eq(3)
+        expect(child3.position).to eq(2)
+
+        # after reload
+        [child1, child2, child3, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([1, 3, 2])
+        expect(child1.position).to eq(1)
+        expect(child2.position).to eq(3)
+        expect(child3.position).to eq(2)
+      end
+
+      it 'moves an embedded item to bottom position' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child1.move_to!(2)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
+
+      it 'moves an embedded item to bottom position by symbol' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child1.move_to!(:bottom)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
+
+      it 'moves an embedded item below bottom position' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child1.move_to!(3)
+
+        # before reload
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+
+        # after reload
+        [child1, child2, parent].each(&:reload)
+        expect(parent.embedded_orderables.map(&:position)).to eq([2, 1])
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+      end
     end
 
-    it 'move_to moves an item returned by a query to position when saving the parent' do
-      parent = EmbedsOrderable.first
-      child1 = parent.embedded_orderables.where(position: 1).first
-      child2 = parent.embedded_orderables.where(position: 2).first
-      child1.move_to(2)
-      parent.save!
-      expect(child1.reload.position).to eq(2)
-      expect(child2.reload.position).to eq(1)
+    context '#move_to' do
+      it 'move_to moves an item returned by a query to position when saving the parent' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child1.move_to(2)
+
+        # does not move position before saving
+        expect(child1.position).to eq(1)
+        expect(child2.position).to eq(2)
+
+        parent.save!
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+        expect(child1.reload.position).to eq(2)
+        expect(child2.reload.position).to eq(1)
+      end
     end
 
-    it 'move_to= moves an item returned by a query to position when saving the parent' do
-      parent = EmbedsOrderable.first
-      child1 = parent.embedded_orderables.where(position: 1).first
-      child2 = parent.embedded_orderables.where(position: 2).first
-      child1.move_to = 2
-      parent.save!
-      expect(child1.reload.position).to eq(2)
-      expect(child2.reload.position).to eq(1)
+    context '#move_to=' do
+      it 'move_to= moves an item returned by a query to position when saving the parent' do
+        parent = EmbedsOrderable.first
+        child1 = parent.embedded_orderables.where(position: 1).first
+        child2 = parent.embedded_orderables.where(position: 2).first
+        child1.move_to = 2
+
+        # does not move position before saving
+        expect(child1.position).to eq(1)
+        expect(child2.position).to eq(2)
+
+        parent.save!
+        expect(child1.position).to eq(2)
+        expect(child2.position).to eq(1)
+        expect(child1.reload.position).to eq(2)
+        expect(child2.reload.position).to eq(1)
+      end
     end
   end