Add typescript definitions #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
reviewed
May 6, 2024
| @@ -0,0 +1,9 @@ | |||
| import { Schema } from "mongoose"; | |||
| declare namespace wrapCallback { | |||
There was a problem hiding this comment.
What is this declare namespace call about? Shouldn't we just have interface WrapCallbackOptions {} and just use that? And export default function wrapCallback()?
There was a problem hiding this comment.
I'm not sure why, but without the namespace I get the following error.
test.ts:1:31 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.
1 import * as wrapCallback from '.';
test.ts is:
import * as wrapCallback from '.';
wrapCallback({} as any);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.