Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang): add punjabi language (@SajanGhuman) #6059

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(lang): add punjabi language (@SajanGhuman) #6059

wants to merge 3 commits into from

Conversation

SajanGhuman
Copy link

Description

This PR adds Punjabi language to the list of languages

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 19, 2024
Miodec
Miodec requested changes Nov 21, 2024
View reviewed changes
frontend/static/languages/_list.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change in this file, its modifying every line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Code Formatter was at fault. Changes made accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you please merge this. Let me know, if any changes are needed.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@SajanGhuman SajanGhuman force-pushed the feat/add_punjabi_language branch from 55b4d18 to e8ca9a6 Compare November 21, 2024 14:35
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@SajanGhuman SajanGhuman force-pushed the feat/add_punjabi_language branch from 853e3c2 to a3e14a2 Compare November 21, 2024 15:20
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Nov 28, 2024
@github-actions github-actions bot removed the Stale Has not been updated in a while label Dec 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Miodec requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff Stale Has not been updated in a while waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SajanGhuman @Miodec @monkeytypegeorge