Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(quotes): add english quotes (@donotdisturbdnd) #6098

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

donotdisturbdnd
Copy link

@donotdisturbdnd donotdisturbdnd commented Dec 6, 2024

Description

Added quotes from music and books that I have read that I think would be good additions.

English:
You let yourself get cold, shiver, hug yourself in your jacket, feel the tips of your fingers start to numb. You climb out, make your way to the lone white door with its gold knob rusted and dulled, all gleam and shimmer aged and gone. You twist, push the door open, hear the wood whine.
Length: 287

Spanish:
Te dejas sentir frío, tiemblas, te abrazas dentro de tu chaqueta, sientes cómo las puntas de tus dedos comienzan a entumecerse. Sales, te diriges a la solitaria puerta blanca con su pomo dorado oxidado y apagado, todo su brillo y resplandor envejecidos y desaparecidos. Giras, empujas la puerta, escuchas el quejido de la madera.
Length: 329


Let me know if you'd like to tweak the description further!

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 6, 2024
@donotdisturbdnd
Copy link
Author

Changing the title since it was incorrect format (capitalized "I")

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@donotdisturbdnd donotdisturbdnd changed the title Impr(quotes) add english quotes @donotdisturbdnd impr(quotes): add english quotes (@donotdisturbdnd) Dec 6, 2024
@Miodec
Copy link
Member

Miodec commented Dec 9, 2024

The diff is huge, you probably changed all spaces to tabs. Please fix.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 9, 2024
Copy link
Author

@donotdisturbdnd donotdisturbdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is "tabbed", as when I'm checking into the code editor, it appears that none of my quotes appear to have a tab. I even checked the find and replace function, and have yet to find an issue.

It is also very possible that I have no clue what you're talking about when you say "replacing tabs with spaces" to something I physically have to do in the coding editor, as I attempted to search up a definition for what to do, yet to no avail.

I do apologize for my lack of understanding of the topic at hand, but if I could have assistance on what exactly the issue may be, it would be greatly appreciated.

@donotdisturbdnd
Copy link
Author

Update, I believe I understand what you mean by the difference is huge.

I had only provided one translation for a single quote, but when you looked at the file, you saw a LOT more than that one quote, because I failed to provide translations for those quotes, so you believed that everything I had done was indented.

If you could confirm or deny this statement, it would be wonderful, and I will begin translating them so you can verify their integrity.

Best regards,
@donotdisturbdnd

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 10, 2024
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@donotdisturbdnd
Copy link
Author

@Miodec I'm terribly sorry for the ping, but I will provide the rest of the quotes (because that what I'm assuming the issue is.)
If you need translations (all the quotes were originally in English and NOT translated from another language,) then please let me know.

ids: 7620 - 7636
"Tell me dear lady, how will you navigate an uncertain future, without the knowledge of the past?"

"I have to work harder than anyone else to make it! I'll never catch up otherwise!"

"Sometimes, the inner voice is encouraging. Calling for you to run those final few yards, you're nearly there, keep going, keep going, or urging you to calm down because you know it will all be okay in the end."

"But it's not a beautiful thing because nobody knows what's in the cup, that's the whole thing. Unless you come up and drink what's in my cup, then how can you say it's a beautiful thing?"

"I don't think this is trash. If you're going to throw it away, I'll take it. I made the decision to consider my feelings more. And you need to pick up things you feel are important."

"If I'm able to change, then everyone else should be able to as well. That means no one is worthless."

"Remember that pain and how good it feels, Onigawara. The one you're looking for is also fighting within himself. So you should change, too."

"If I'm going to be shackled by fear and brainwashed, I'd rather try to escape, even if it means I could die."

"So part of him wanted to tell Nath that he knew: what it was like to be teased, what it was like to never fit in. The other part of him wanted to shake his son, to slap him. To shape him into something different."

"Fancy thinking the Beast was something you could hunt and kill! You knew, didn't you? I'm part of you? Close, close, close! I'm the reason why it's no go? Why things are what they are?"

"There have been so many interpretations of the story that I'm not going to choose between them. Make your own choice. They contradict each other, the various choices. The only choice that really matters, the only interpretation of the story, if you want one, is your own. Not your teacher's, not your professor's, not mine, not a critic's, not some authority's. The only thing that matters is, first, the experience of being in the story, moving through it. Then any interpretation you like. If it's yours, then that's the right one, because what's in a book is not what an author thought he put into it, it's what the reader gets out of it."

"This song is just as comforting as it is painful. Making it was really difficult, I felt like I was failing my family because I didn't want to pursue an education or get a 'real job', but who are they to tell you what to do? So I guess this is just a reflection on the past. It hurts knowing you can't change the past, but that's okay, because there are so many new memories to make and so many new faces to meet."

"I felt like the minute I moved out, my youth would be over and I'd hardly ever see my family or dog again. In reality it wasn't like that at all, I still see them all the time. But I wanted to capture the sad side of growing up: of realizing your parents aren't infallible."

"I finally get a bouquet and it's a goodbye present. That's depressing."

"It's hard to grieve the dead, it's harder to grieve the living, 'cause when they're under stone, you know they're not still out there giving their love to someone else."

"We did that often, asking each other questions whose answers we already knew. Perhaps it was so that we would not ask the other questions, the ones whose answers we did not want to know."

"You let yourself get cold, shiver, hug yourself in your jacket, feel the tips of your fingers start to numb. You climb out, make your way to the lone white door with its gold knob rusted and dulled, all gleam and shimmer aged and gone. You twist, push the door open, hear the wood whine."

@donotdisturbdnd
Copy link
Author

(Also fixed replaced a comma with a period at the end of a sentence (typo)

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 23, 2024
@Miodec
Copy link
Member

Miodec commented Dec 23, 2024

Diff is still huge
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants