Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spanish.json #6106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update spanish.json #6106

wants to merge 1 commit into from

Conversation

Libz24
Copy link

@Libz24 Libz24 commented Dec 10, 2024

impr(quotes): add spanish quotes (@Libz24 )

Description

More philosophy and poetry quotes for spanish

Checks

  • Adding quotes?

Quotes added

People of different trades or classes, who have nothing in common, living near each other by chance, are combined into an artificial group that has to be represented by a delegate.

The more love you give, the better you are (this one is not 100% correct, in spanish saying "Mejor estás" can be interpreted as something like saying "the better you feel and the better you see yourself")

The poor had to stand and the rich had boxes. But there was something that united the banker and the poor: the hatred of beauty.

Nobody understood that phrase and it causes me some difficulty explaining what Teresa meant when she compared a nudist beach to the Russian invasion.

A look from the sewer can be a vision of the world, rebellion consists of looking at a rose until your eyes are pulverized. (this one is poetry so the meaning and the depth cannot be 100% correctly translated)

@Libz24

Closes #

There´s not that many quotes for spanish. An hour of playing is enough to start getting the same ones over and over

Added Quotes
Copy link
Contributor

github-actions bot commented Dec 10, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Update spanish.json". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - impr
 - fix
 - perf
 - refactor
 - revert
 - style
 - test

A correct version would look something like:

feat: add new feature (@github-username)
impr(quotes): add english quotes (@github-username)
fix: resolve bug (@github-username)

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 10, 2024
@Miodec
Copy link
Member

Miodec commented Dec 23, 2024

I only really like the second quote, please remove the rest. Also please update the pr title.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants