feat: onNavigateToNextSight callback (MN-504)

monkvision · Apr 26, 2024 · 465c143 · 465c143
1 parent aef54cf
commit 465c143
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/packages/camera/src/components/Capture/capture.js b/packages/camera/src/components/Capture/capture.js
@@ -133,6 +133,7 @@ const Capture = forwardRef(({
   onReady,
   onStartUploadPicture,
   onFinishUploadPicture,
+  onNavigateToNextSight,
   orientationBlockerProps,
   overlayPathStyles,
   primaryColor,
@@ -352,6 +353,17 @@ const Capture = forwardRef(({
     }
   }, [setAddDamageStatus, lastAddDamageHelpTimestamp]);
 
+  const handleOnFinishUploadPicture = useCallback(async () => {
+    try {
+      await onNavigateToNextSight();
+    } catch (err) {
+      log([`Error in \`<Capture />\` \`goNextSight()\`: ${err}`], 'err');
+    } finally {
+      api.goNextSight();
+      onFinishUploadPicture();
+    }
+  }, [api]);
+
   const handleResetDamageStatus = useCallback(() => {
     setAddDamageStatus(AddDamageStatus.IDLE);
     setAddDamageParts([]);
@@ -610,7 +622,7 @@ const Capture = forwardRef(({
       onCloseEarly={handleCloseEarlyClick}
       onAddDamagePressed={handleAddDamagePressed}
       onStartUploadPicture={onStartUploadPicture}
-      onFinishUploadPicture={onFinishUploadPicture}
+      onFinishUploadPicture={handleOnFinishUploadPicture}
       addDamageParts={addDamageParts}
       onResetAddDamageStatus={handleResetDamageStatus}
       hideAddDamage={hideAddDamage}
@@ -857,6 +869,7 @@ Capture.propTypes = {
   onComplianceCheckFinish: PropTypes.func,
   onComplianceCheckStart: PropTypes.func,
   onFinishUploadPicture: PropTypes.func,
+  onNavigateToNextSight: PropTypes.func,
   onPictureTaken: PropTypes.func,
   onPictureUploaded: PropTypes.func,
   onReady: PropTypes.func,
@@ -976,6 +989,7 @@ Capture.defaultProps = {
   onComplianceCheckFinish: () => { },
   onComplianceCheckStart: () => { },
   onFinishUploadPicture: () => { },
+  onNavigateToNextSight: () => { },
   onWarningMessage: () => { },
   onReady: () => { },
   onStartUploadPicture: () => { },

diff --git a/packages/camera/src/components/Controls/index.js b/packages/camera/src/components/Controls/index.js
@@ -156,12 +156,10 @@ export default function Controls({
     if (action === Actions.sights.ADD_PROCESS_TO_QUEUE) {
       if (noOfProcesses < MAX_LIMIT_FOR_PROCESSES && current.index !== (ids.length - 1)) {
         onFinishUploadPicture(state, api);
-        api.goNextSight();
       }
     } else if (action === Actions.sights.REMOVE_PROCESS_FROM_QUEUE) {
       if (noOfProcesses === (MAX_LIMIT_FOR_PROCESSES - 1) && current.index !== (ids.length - 1)) {
         onFinishUploadPicture(state, api);
-        api.goNextSight();
       }
     }
   }, [state.sights.state.process]);

diff --git a/website/docs/js/api/components/Capture.md b/website/docs/js/api/components/Capture.md
@@ -46,6 +46,7 @@ export default function Inspector({ inspectionId }) {
         onReady={() => setLoading(false)}
         onStartUploadPicture={() => setLoading(true)}
         onFinishUploadPicture={() => setLoading(false)}
+        onNavigateToNextSight={onNavigateToNextSight}
         onChange={handleChange}
         sightIds={Constants.defaultSightIds}
       />
@@ -93,6 +94,7 @@ export default function Inspector({ inspectionId }) {
         onReady={() => setLoading(false)}
         onStartUploadPicture={() => setLoading(true)}
         onFinishUploadPicture={() => setLoading(false)}
+        onNavigateToNextSight={onNavigateToNextSight}
         onChange={handleChange}
         sightIds={Constants.defaultSightIds}
       />
@@ -468,6 +470,11 @@ const handleStartUploadPicture = (state, api) => console.log('Started uploading
 
 Will call a function when the uploading is finished for every picture.
 
+## onNavigateToNextSight
+`PropTypes.func`
+
+Will call a function before navigating to next sight.
+
 ```js
 const handleFinishUploadPicture = (state, api) => console.log('Finished uploading a picture');
 ```