🐛 svg styles override unintentionally #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunachalam-monk
force-pushed
the
fix/MN-554/sights-display-black-in-docs
branch
from
2a3419f
to
66782c2
Compare
arunachalam-monk
force-pushed
the
fix/MN-554/sights-display-black-in-docs
branch
2 times, most recently
from
1577ef6
to
58d6903
Compare
arunachalam-monk
force-pushed
the
fix/MN-554/sights-display-black-in-docs
branch
from
58d6903
to
9b9dcf1
Compare
arunachalam-monk
force-pushed
the
fix/MN-554/sights-display-black-in-docs
branch
from
c1f4466
to
e890f36
Compare
packages/common-ui-web/src/components/DynamicSVG/hooks/useJSXTransformAttributes.ts
Outdated
Show resolved
Hide resolved
packages/common-ui-web/src/components/DynamicSVG/hooks/useJSXTransformAttributes.ts
Outdated
Show resolved
Hide resolved
packages/common-ui-web/src/components/DynamicSVG/hooks/useJSXTransformAttributes.ts
Outdated
Show resolved
Hide resolved
packages/common-ui-web/test/components/DynamicSVG/hooks/useCustomAttributes.test.ts
Show resolved
Hide resolved
arunachalam-monk
force-pushed
the
fix/MN-554/sights-display-black-in-docs
branch
from
8319c26
to
6444538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira Ticket Reference : MN-554
seems
getAttributesis used to add styles it unintentionally overrides the style.