New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/mn 566/vehicle part selection #812

Merged

arunachalam-monk merged 22 commits into main from feat/MN-566/vehicle-part-selection

Jul 29, 2024

Contributor

arunachalam-monk commented Jul 16, 2024 •

edited

Loading

Overview

Jira Ticket Reference : MN-566

Add 2 components to show the vehicle selection wireframe

Checklist before requesting a review

I have updated the unit tests based on the changes I made
I have updated the docs (TSDoc / README / global doc) to reflect my changes
I have performed self-QA of my feature by testing the apps and packages and made sure that :
- No regression or new bug has occurred
- The acceptance criteria listed in the ticket are met
- Self-QA was made on both desktop and mobile

arunachalam-monk force-pushed the feat/MN-566/vehicle-part-selection branch from 1f87219 to a6050d9 Compare

July 16, 2024 10:44

souyahia-monk reviewed

View reviewed changes

packages/types/src/sights.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/types/src/sights.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/types/src/sights.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/build/buildJSONs.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/lib/data.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/types/src/sights.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/types/src/sights.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/lib/data.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/src/lib/data.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/test/build/buildJSON.test.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/test/build/buildJSON.test.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/sights/test/build/buildJSON.test.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

configs/test-utils/src/expects/props.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

configs/test-utils/src/expects/props.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

nx.json Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/DynamicSVG/hooks/useCustomAttributes.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/icons/assets.ts Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/VehicleDynamicWireframe/VehicleDynamicWireframe.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/VehicleDynamicWireframe/VehicleDynamicWireframe.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/VehicleDynamicWireframe/VehicleDynamicWireframe.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/VehicleDynamicWireframe/VehicleDynamicWireframe.tsx Outdated Show resolved Hide resolved

souyahia-monk reviewed

View reviewed changes

packages/common-ui-web/src/components/VehicleDynamicWireframe/VehicleDynamicWireframe.tsx Show resolved Hide resolved

arunachalam-monk commented

View reviewed changes

Contributor Author

arunachalam-monk left a comment

completed the changes.

nx.json Outdated Show resolved Hide resolved

packages/common-ui-web/src/components/DynamicSVG/hooks/useCustomAttributes.ts Outdated Show resolved Hide resolved

packages/common-ui-web/src/components/DynamicSVG/hooks/useCustomAttributes.ts Outdated Show resolved Hide resolved

packages/common-ui-web/src/icons/assets.ts Outdated Show resolved Hide resolved

packages/types/src/sights.ts Outdated Show resolved Hide resolved

dlymonkai and others added 19 commits

July 25, 2024 15:37


          Added wireframes SVG

950dcf4


          wip on types

009e91a


          ✨ add part selection wire frame to sights

20e2757


          ⚡️ wireframe to apply different svgo rules

3903b81

adding prefix to ID and class name
we can't able to get part name correctly


          ⬆️ use group elements instead of groupIds

5d462e7


          ✨add vehicle wireframe component

f67653d

🚧 need to add docs, global docs, test


          ⚡️ add states to handle from multiple view


          ✨ add rotate left and rotate right icon


          ✅add tests

073da75


          ♻️ remove generics to make it much simpler

c811e12


          📝global docs for vehicle wireframe selection

182c8a3


          ✅ fix linting

f8cd7bb


          ✅ add test for build wireframe

4dec492


          ♻️ modify VehicleDynamicWireframe to move styling to it's parent

fb6ea02


          👌 rename wireFrame, vehicleModel, test util function

f6df517


          👌 add more standardized comments

e0d07fc


          ♻️ move components to folders

b43db77


          ♻️ remove VehicleTypeMapVehicleModel

03e8344


          👌 add correct tsdocs

7bc1509

arunachalam-monk force-pushed the feat/MN-566/vehicle-part-selection branch from 807186a to 98b849d Compare

July 25, 2024 10:07


          👕 add if to be block, set max width of code

90b23ac

arunachalam-monk force-pushed the feat/MN-566/vehicle-part-selection branch from 98b849d to 90b23ac Compare

July 25, 2024 10:10


          👌 missing changes

ef1798d

arunachalam-monk force-pushed the feat/MN-566/vehicle-part-selection branch from 19e6ee4 to ef1798d Compare

July 25, 2024 13:43

souyahia-monk approved these changes

View reviewed changes


          ✅ onPartSelected is wrong

b824dd1

arunachalam-monk requested review from arunachaleshwaran and removed request for arunachaleshwaran

July 26, 2024 08:10

arunachalam-monk merged commit fc85fc2 into main

4 checks passed

arunachalam-monk deleted the feat/MN-566/vehicle-part-selection branch

July 29, 2024 06:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet