Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/mn 584/specfic error message camera #817

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Feat/mn 584/specfic error message camera #817

merged 6 commits into from
Sep 4, 2024

Conversation

arunachalam-monk
Copy link
Contributor

@arunachalam-monk arunachalam-monk commented Aug 1, 2024 •
edited by jira bot
Loading

Overview

Jira Ticket Reference : MN-584

Checklist before requesting a review

  • I have updated the unit tests based on the changes I made
  • I have updated the docs (TSDoc / README / global doc) to reflect my changes
  • I have performed self-QA of my feature by testing the apps and packages and made sure that :
    • No regression or new bug has occurred
    • The acceptance criteria listed in the ticket are met
    • Self-QA was made on both desktop and mobile

souyahia-monk
souyahia-monk requested changes Aug 1, 2024
View reviewed changes
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
packages/camera-web/src/Camera/hooks/useUserMedia.ts Outdated Show resolved Hide resolved
@arunachalam-monk arunachalam-monk force-pushed the feat/MN-584/specfic-error-message-camera branch from 808e2f4 to c7ddbe0 Compare August 1, 2024 13:33
@arunachalam-monk arunachalam-monk force-pushed the feat/MN-584/specfic-error-message-camera branch from c7ddbe0 to 5614aee Compare August 2, 2024 05:23
arunachalam-monk
arunachalam-monk commented Aug 2, 2024
View reviewed changes
Copy link
Contributor Author

@arunachalam-monk arunachalam-monk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you put async here?

now its removed. previously i implement the permission call inside that. now it's changed

@arunachalam-monk arunachalam-monk force-pushed the feat/MN-584/specfic-error-message-camera branch from 307f00d to c876698 Compare August 5, 2024 08:44
@arunachalam-monk arunachalam-monk merged commit f0976a7 into main Sep 4, 2024
4 checks passed
@arunachalam-monk arunachalam-monk deleted the feat/MN-584/specfic-error-message-camera branch September 4, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlymonkai dlymonkai dlymonkai approved these changes

@souyahia-monk souyahia-monk souyahia-monk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunachalam-monk @souyahia-monk @dlymonkai