Sksafemath additions (DEPENDANT PR) #2156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add /.idea to git ignore (mono#2138)
|
Thanks for this PR and the work. However, I do not think this is used much outside of internal things in skia. To reduce maintenance overhead, I want to keep the API at a minimum. If this is ever needed in SkiaSharp or provides some significant benefit we can reopen. This safe math feature is probably just worth doing in the various places that actually do math that could overflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
depends on PR #2155
Bugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
#2156
PR Checklist