Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run APIScan after packaging on the packages #2730

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion native/windows/build.cake
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Task("libSkiaSharp")
clang +
win_vcvars_version +
$"extra_cflags=[ '-DSKIA_C_DLL', '/MT{d}', '/EHsc', '/Z7', '-D_HAS_AUTO_PTR_ETC=1' ] " +
$"extra_ldflags=[ '/DEBUG:FULL' ] " +
$"extra_ldflags=[ '/DEBUG:FULL', '/DEBUGTYPE:CV,FIXUP' ] " +
ADDITIONAL_GN_ARGS);

var outDir = OUTPUT_PATH.Combine($"{VARIANT}/{dir}");
Expand Down
6 changes: 6 additions & 0 deletions native/windows/libHarfBuzzSharp/libHarfBuzzSharp.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
Expand All @@ -163,6 +164,7 @@
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">
Expand All @@ -178,6 +180,7 @@
</ClCompile>
<Link>
<SubSystem>Windows</SubSystem>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
Expand All @@ -197,6 +200,7 @@
<SubSystem>Windows</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
Expand All @@ -216,6 +220,7 @@
<SubSystem>Windows</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">
Expand All @@ -235,6 +240,7 @@
<SubSystem>Windows</SubSystem>
<EnableCOMDATFolding>true</EnableCOMDATFolding>
<OptimizeReferences>true</OptimizeReferences>
<AdditionalOptions>/DEBUGTYPE:CV,FIXUP</AdditionalOptions>
</Link>
</ItemDefinitionGroup>
<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions scripts/azure-pipelines-variables.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
variables:
SKIASHARP_MAJOR_VERSION: 3
SKIASHARP_VERSION: 3.0.0
FEATURE_NAME_PREFIX: 'feature/'
VERBOSITY: normal
Expand Down
4 changes: 4 additions & 0 deletions scripts/azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ parameters:
pool:
name: Azure Pipelines
vmImage: ubuntu-20.04
- name: runCompliance
type: boolean
default: false

variables:
- template: azure-pipelines-variables.yml
Expand All @@ -54,6 +57,7 @@ stages:
parameters:
buildPipelineType: 'build'
buildExternals: ${{ parameters.buildExternals }}
runCompliance: ${{ parameters.runCompliance }}
VM_IMAGE_HOST: ${{ parameters.VM_IMAGE_HOST }}
VM_IMAGE_WINDOWS: ${{ parameters.VM_IMAGE_WINDOWS }}
VM_IMAGE_WINDOWS_NATIVE: ${{ parameters.VM_IMAGE_WINDOWS }}
Expand Down
26 changes: 17 additions & 9 deletions scripts/azure-templates-stages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -880,18 +880,14 @@ stages:
- template: security/full/v1.yml@xamarin-templates
parameters:
stageDependsOn:
- managed
- native_windows
- native_macos
- native_linux
- native_wasm
- package
complianceEnabled: true
complianceTimeoutInMinutes: 480
scanArtifacts:
- managed
- native
- nuget
- nuget_symbols
antiMalwareEnabled: true
binSkimEnabled: true
binSkimEnabled: false
policheckExclusionFile: $(Build.SourcesDirectory)\scripts\guardian\PoliCheckExclusions.xml
policheckGdnSuppressionFilesFolder: $(Build.SourcesDirectory)\scripts\guardian
credScanEnabled: true
Expand All @@ -902,7 +898,19 @@ stages:
enableCodeInspector: true
apiScanEnabled: true
apiScanSoftwareName: 'SkiaSharp'
apiScanSoftwareVersionNum: $(Build.BuildNumber)
apiScanSoftwareVersionNum: $(SKIASHARP_MAJOR_VERSION)
apiScanPreserveLogsFolder: true
preScanSteps:
- pwsh: |
$nupkgs = (Get-ChildItem "$(Build.ArtifactStagingDirectory)\binaries-to-scan\*\*.*nupkg")
foreach ($nupkg in $nupkgs) {
$filename = $nupkg.Name.TrimEnd('.nupkg')
$dest = "$(Build.ArtifactStagingDirectory)\binaries-to-scan\nuget_symbols-extracted\$filename"
Write-Host "Extracting '$nupkg' to '$dest'..."
Expand-Archive $nupkg $dest
Remove-Item $nupkg
}
displayName: Extract all the .nupkg files

- ${{ if eq(parameters.buildPipelineType, 'tests') }}:
- stage: finalize
Expand Down
Loading