Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R-Tree overload of beginRecording #2889

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Add R-Tree overload of beginRecording #2889

merged 3 commits into from
Jun 18, 2024

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Jun 4, 2024

Description of Change

Add the R-Tree overload of SKPicture.BeginRecording.

The R-Tree factory type (SkRTreeFactory) or any other SkBBHFactory types are not exposed since it is fairly complicated and not many use cases. It can be added later. For now, we just have a boolean flag indicating whether to use it or not.

Bugs Fixed

API Changes

class SKPicture {
    public SKCanvas BeginRecording (SKRect cullRect, bool useRTree);
}

Behavioral Changes

None.

Required skia PR

mono/skia#129

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow changed the title Add R-Tree overload to beginRecording Add R-Tree overload of beginRecording Jun 4, 2024
@mattleibow mattleibow merged commit 463dd82 into main Jun 18, 2024
2 checks passed
@mattleibow mattleibow deleted the dev/rtree branch June 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Expose existing RTree optimization option on SkPictureRecorder.BeginRecording()
1 participant