Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SKPaint.FilterQuality instead of SKSamplingOptions.Default #2924

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

mattleibow
Copy link
Contributor

Description of Change

Use the SKPaint.FilterQuality for the SKSamplingOptions in obsolete methods. In SkiaSharp 3.0, the SKPaint.FilterQuality property is obsolete (removed from the underlying skia API) but we still need to use that value if no sampling options are provided.

Bugs Fixed

  • Fixes #

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow changed the title Use the SKPaint.FilterQuality instead of SamplingOptions.Default Use SKPaint.FilterQuality instead of SKSamplingOptions.Default Jul 4, 2024
@mattleibow mattleibow merged commit 5feff85 into main Jul 5, 2024
1 of 2 checks passed
@mattleibow mattleibow deleted the dev/fix-quality branch July 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant