Enumeration comparisons changed from usage of is to ==

[monocongo]

Addressing #558 we've changed usages of is to == for comparisons of Periodicity and Distribution type arguments. This seems to fix that issue and maybe has something to do with how dask handles enumerated types when passed as arguments, maybe Enum class types don't fit well compared to strings, etc.

Summary by Sourcery

Fix enumeration comparisons by replacing 'is' with '==' for Periodicity and Distribution types to address compatibility issues, potentially related to how 'dask' handles enumerated types.

Bug Fixes:

• Fix enumeration comparisons by replacing the use of 'is' with '==' for Periodicity and Distribution type arguments to ensure correct behavior.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request changes the comparison of enumeration types from using the is operator to the == operator in the climate_indices module. The changes are made to address issue #558, which may be related to how dask handles enumerated types when passed as arguments.

File-Level Changes

Change	Details	Files
Changed enumeration comparisons from is to ==	Updated comparisons for periodicity from is to == Updated comparisons for distribution from is to == Modified error messages to use single quotes around the invalid argument values	src/climate_indices/indices.py
Improved code formatting and comments	Adjusted indentation for better readability Updated comments to be more concise and accurate	src/climate_indices/indices.py

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sourcery-ai]

Hey @monocongo - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}