Move findProviderByCode in Browsable object provider

monsieurbiz · Apr 9, 2024 · 49df1f8 · 49df1f8
1 parent 4a9c6f5
commit 49df1f8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/src/Controller/BrowserController.php b/src/Controller/BrowserController.php
@@ -14,7 +14,6 @@
 namespace MonsieurBiz\SyliusMenuPlugin\Controller;
 
 use MonsieurBiz\SyliusMenuPlugin\Provider\BrowsableObjectProviderInterface;
-use MonsieurBiz\SyliusMenuPlugin\Provider\UrlProviderInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -50,7 +49,7 @@ public function listItemsAction(
         $inputValue = (string) $request->query->get('inputValue', '');
         $locale = (string) $request->query->get('locale', '');
 
-        $urlProvider = $this->findProviderByCode($providerCode);
+        $urlProvider = $this->browsableObjectProvider->findProviderByCode($providerCode);
         if (null === $urlProvider) {
             return new JsonResponse(['error' => 'URL Provider not found'], 404);
         }
@@ -62,16 +61,4 @@ public function listItemsAction(
             'locale' => $locale,
         ]);
     }
-
-    private function findProviderByCode(string $code): ?UrlProviderInterface
-    {
-        /** @var UrlProviderInterface $urlProvider */
-        foreach ($this->browsableObjectProvider->getUrlProviders() as $urlProvider) {
-            if ($urlProvider->getCode() === $code) {
-                return $urlProvider;
-            }
-        }
-
-        return null;
-    }
 }
diff --git a/src/Provider/BrowsableObjectProvider.php b/src/Provider/BrowsableObjectProvider.php
@@ -30,4 +30,16 @@ public function getUrlProviders(): array
 
         return $urlProviders;
     }
+
+    public function findProviderByCode(string $code): ?UrlProviderInterface
+    {
+        /** @var UrlProviderInterface $urlProvider */
+        foreach ($this->getUrlProviders() as $urlProvider) {
+            if ($urlProvider->getCode() === $code) {
+                return $urlProvider;
+            }
+        }
+
+        return null;
+    }
 }
diff --git a/src/Provider/BrowsableObjectProviderInterface.php b/src/Provider/BrowsableObjectProviderInterface.php
@@ -16,4 +16,6 @@
 interface BrowsableObjectProviderInterface
 {
     public function getUrlProviders(): array;
+
+    public function findProviderByCode(string $code): ?UrlProviderInterface;
 }