Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes on item links #32

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Add attributes on item links #32

merged 3 commits into from
Oct 30, 2023

Conversation

Kiwikoti
Copy link
Contributor

Add handling of some attributes for links in menu item:

  • target="_blank"
  • rel="noopener noreferrer nofollow"

Admin:

Capture d’écran 2023-10-27 à 10 40 23

Front:

Capture d’écran 2023-10-27 à 10 40 40

@madamebiz madamebiz added the Status: needs review Needs review label Oct 27, 2023
@jacquesbh jacquesbh merged commit b78f119 into monsieurbiz:master Oct 30, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximehuran maximehuran maximehuran approved these changes

@jacquesbh jacquesbh jacquesbh approved these changes

@delyriand delyriand Awaiting requested review from delyriand

@lanfisis lanfisis Awaiting requested review from lanfisis

Assignees
No one assigned
Labels
Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kiwikoti @jacquesbh @maximehuran @madamebiz