Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HeroUiElement and LinksUiElement #1

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Add HeroUiElement and LinksUiElement #1

merged 6 commits into from
Aug 5, 2024

Conversation

welcoMattic
Copy link
Contributor

@welcoMattic welcoMattic commented Jul 31, 2024 •
edited
Loading

This PR adds

  • HeroUiElement
  • LinksUiElement

RichEditor UiElements list

image

Hero

Form

image

Admin preview

image

Links

image

@welcoMattic welcoMattic requested a review from maximehuran July 31, 2024 12:45
@madamebiz madamebiz added the Status: needs review Needs review label Jul 31, 2024
@welcoMattic welcoMattic changed the title test(dependencies): Ensure RichEditor is required as dependency and used by test app Add HeroUiElement and LinksUiElement Jul 31, 2024
maximehuran
maximehuran requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@maximehuran maximehuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci is broken

@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Needs review labels Aug 1, 2024
@welcoMattic welcoMattic requested a review from maximehuran August 5, 2024 08:19
@madamebiz madamebiz added Status: needs review Needs review and removed Status: needs update This Issue/PR needs update labels Aug 5, 2024
@welcoMattic welcoMattic merged commit ef86cda into master Aug 5, 2024
5 checks passed
@welcoMattic welcoMattic deleted the feature/first-set-of-ui-elements branch August 5, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximehuran maximehuran Awaiting requested review from maximehuran

Assignees
No one assigned
Labels
Status: needs review Needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@welcoMattic @maximehuran @madamebiz