Bump squizlabs/php_codesniffer to 3.9.0 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=========================================
Coverage 96.73% 96.73%
Complexity 586 586
=========================================
Files 26 26
Lines 1625 1625
=========================================
Hits 1572 1572
Misses 53 53 ☔ View full report in Codecov by Sentry. |
Also, bump PHPCompatibility to current dev version (e5cd2e24) We were using version 9.3.5 that is from December 2019. Since then lots of new sniffs and compatibility with PHP 8.x versions have been provided. So, while not ideal, let's use the dev version in the mean time.
stronk7
force-pushed
the
bump_to_phpcs_3_9_0
branch
from
5775a07
to
576b398
Compare
andrewnicols
approved these changes
Feb 18, 2024
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, bump PHPCompatibility to current dev version (e5cd2e24)
We were using version 9.3.5 that is from December 2019. Since then lots of new sniffs and compatibility with PHP 8.x versions have been provided.
So, while not ideal, let's use the dev version in the mean time.