Properties should not be tested for regular constructors (Fixes #142) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
variableCommentOnConstructor
branch
from
27dbb25
to
582195e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=========================================
Coverage 97.88% 97.88%
- Complexity 844 845 +1
=========================================
Files 37 37
Lines 2500 2509 +9
=========================================
+ Hits 2447 2456 +9
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
force-pushed
the
variableCommentOnConstructor
branch
from
582195e
to
287652f
Compare
…ehq#142) Only properties which define a visibility and therefore are promoted constructor properties are required to define a variable docblock.
andrewnicols
force-pushed
the
variableCommentOnConstructor
branch
from
287652f
to
e7506b1
Compare
stronk7
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only properties which define a visibility and therefore are promoted constructor properties are required to define a variable docblock.