Tags for file-specific paths should normalise pathnames #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=========================================
Coverage 97.89% 97.90%
- Complexity 849 850 +1
=========================================
Files 37 37
Lines 2517 2524 +7
=========================================
+ Hits 2464 2471 +7
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
force-pushed
the
phpunitTags
branch
6 times, most recently
from
2e9ab4e
to
715b43e
Compare
andrewnicols
changed the title
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 3, 2024
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 3, 2024
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 3, 2024
andrewnicols
added a commit
to andrewnicols/moodle-cs
that referenced
this pull request
Apr 3, 2024
andrewnicols
force-pushed
the
phpunitTags
branch
from
715b43e
to
3639ade
Compare
sarjona
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Hi @andrewnicols!
Thanks for working on this improvement. It's great to see Windows support too. Well done! I love the way you split commits (it always helps to better understanding the code) <3
I'm happy to approve this change and merge it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.