Object names may not be present for all objects #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
referenced
this pull request
Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=========================================
Coverage 97.88% 97.89%
- Complexity 845 849 +4
=========================================
Files 37 37
Lines 2509 2517 +8
=========================================
+ Hits 2456 2464 +8
Misses 53 53 ☔ View full report in Codecov by Sentry. |
andrewnicols
force-pushed
the
objectDeclarationReturnNullable
branch
from
de8408f
to
b95a7a8
Compare
sarjona
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Hi @andrewnicols!
Thanks for fixing this issue. The patch makes sense, so I'm happy to approve and merge it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @ewallah via commit comment here: 237cf60#commitcomment-140496069