Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MissingDoclock code more specific (Fixes #154) #156

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

andrewnicols
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (3961e3c) to head (f3675a6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #156   +/-   ##
=========================================
  Coverage     98.03%   98.03%           
  Complexity      901      901           
=========================================
  Files            40       40           
  Lines          2697     2697           
=========================================
  Hits           2644     2644           
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me... I just have one suggestion...

Maybe it wouldn't be crazy to amend some of the related tests expectations and ensure that the new "codes" are being returned properly?

@andrewnicols
Copy link
Contributor Author

Agree - I'll try and set some time aside to do this.

@stronk7 stronk7 linked an issue Jun 14, 2024 that may be closed by this pull request
@stronk7 stronk7 force-pushed the missingDocblockMoreSpecific branch from cb0d73b to f3675a6 Compare June 14, 2024 07:11
@stronk7
Copy link
Member

stronk7 commented Jun 14, 2024

Hi,

I've resolved conflicts here, added some specific code tests and amended the sniff slightly to ensure that the 1st char in the code is always upper (that is good practice, I think).

Will be merging this soon...

@stronk7 stronk7 merged commit 22b99c9 into moodlehq:main Jun 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make MissingDocblock names more specific
2 participants