Revert "Lower the "and" and "or" uses down from error to warning" #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c85e30f. Fixes moodlehq#5.
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 95.53% 95.53%
Complexity 440 440
=========================================
Files 19 19
Lines 1165 1165
=========================================
Hits 1113 1113
Misses 52 52 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrchamp
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One year ago we decided to keep these as warnings until August 2023. Now, it's August 2023, hence, moving the uses of "and" and "or" back to error.
This reverts commit c85e30f.
Fixes #5.