Add a new moodle-extra coding style

[andrewnicols]

As dicussed in #45, and #25 it would be good to have a strict option.

This is an attempt largely based on the one I use daily (https://github.com/andrewnicols/moodle-cs-strict) with a few additions and removals.

[codecov]

Codecov Report

Merging #57 (d7a9810) into main (57bd4db) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #57   +/-   ##
=========================================
  Coverage     95.53%   95.53%           
  Complexity      440      440           
=========================================
  Files            19       19           
  Lines          1165     1165           
=========================================
  Hits           1113     1113           
  Misses           52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stronk7]

I like this, and we can go promoting things from the "extra" ruleset to the "normal" one while things evolve...

BTW, does "extra" sound ok for you? For some reason (not sure why, to be honest, maybe because of Spanish...) I'm not sure. Maybe "plus", "strict", "get_it_serious" (lol)...

In any case I'm not strong at all with the above, if you're happy with "extra", I'm happy too. Just tell and I will proceed.

Ciao :-)

[andrewnicols]

BTW, does "extra" sound ok for you? For some reason (not sure why, to be honest, maybe because of Spanish...) I'm not sure. Maybe "plus", "strict", "get_it_serious" (lol)...

I went for extra because that's what WordPress do for theirs: https://github.com/WordPress/WordPress-Coding-Standards#standards-subsets

Their description is:

extended ruleset with recommended best practices, not sufficiently covered in the WordPress core coding standards

I've also taken the liberty of updating the readme here to:

• describe both of the coding tsyles
• update information on how to use the new coding styles
• remove the old information on configuration (moodle-local_codecheck is now wrong, and the other options are far from ideal).

[stronk7]

Here we go! (note, I'll be making a release later today if that's ok for you)

[andrewnicols]

Works for me.

I considered adding some more rules but I feel we should add unit tests for what we have first.

I was also wondering about writing a sniff for data providers to make them statically defined.

[stronk7]

Thanks @andrewnicols,

it looks great!