Check validity of unit test dataProviders #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
force-pushed
the
unitTests
branch
3 times, most recently
from
6adc9f7
to
a37dcab
Compare
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
============================================
+ Coverage 95.62% 96.24% +0.61%
- Complexity 445 492 +47
============================================
Files 20 21 +1
Lines 1188 1384 +196
============================================
+ Hits 1136 1332 +196
Misses 52 52
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andrewnicols
force-pushed
the
unitTests
branch
from
a37dcab
to
f310cd2
Compare
andrewnicols
force-pushed
the
unitTests
branch
3 times, most recently
from
3b1de9a
to
5ce6e4b
Compare
andrewnicols
force-pushed
the
unitTests
branch
3 times, most recently
from
7a8e3de
to
ed9eba9
Compare
This change includes: - detection of private providers - detection of providers which do not exist - detection of incorrect casing of the dataProvider declaration - detection of providers which do not have a correct return type - detection of providers which are not static - detection of providers whose names start with test_ Fixes moodlehq#42
andrewnicols
force-pushed
the
unitTests
branch
from
ed9eba9
to
ae762af
Compare
stronk7
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes: