Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move phpcs from squizlabs to phpcsstandards #83

Merged

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Dec 2, 2023

PHP_Codesniffer is being abandoned by squizlabs. See:

squizlabs/PHP_CodeSniffer#3932 (old org) PHPCSStandards/PHP_CodeSniffer#109 (new org)

So it has been moved (copied "manually", not transferred, not good, squizlabs) to the PHPCSStandards organisation.

So this PR just moves us to start using the new organisation. Let's see how things evolve. It would be so great if the new one gets some support... (right now it's a 1-person project, basically).

PHP_Codesniffer is being abandoned by squizlabs. See:

squizlabs/PHP_CodeSniffer#3932 (old org)
PHPCSStandards/PHP_CodeSniffer#109 (new org)

So it has been moved (copied, not transferred, not good, squizlabs)
to the PHPCSStandards organisation.

So this PR just moves us to start using the new organisation. Let's
see how things evolve. It would be so great if the new one gets some
support... (right now it's a 1-person project, basically).
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a415a54) 96.17% compared to head (1e6613d) 96.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #83   +/-   ##
=========================================
  Coverage     96.17%   96.17%           
  Complexity      543      543           
=========================================
  Files            23       23           
  Lines          1542     1542           
=========================================
  Hits           1483     1483           
  Misses           59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrchamp
Copy link
Contributor

jrchamp commented Dec 3, 2023

So this PR just moves us to start using the new organisation. Let's see how things evolve. It would be so great if the new one gets some support... (right now it's a 1-person project, basically).

Any chance Martin could be convinced to sponsor? 😃 https://github.com/sponsors/PHPCSStandards I'll definitely be asking my org if we can do something too.

Copy link
Contributor

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eloy! Looks spot-on. Moving this forward!

@junpataleta junpataleta merged commit 009aa39 into moodlehq:main Dec 4, 2023
7 checks passed
@stronk7 stronk7 deleted the move_from_squizlabs_to_phpcsstandards branch December 4, 2023 16:52
@jrfnl
Copy link

jrfnl commented Dec 7, 2023

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

@stronk7
Copy link
Member Author

stronk7 commented Dec 7, 2023

Grrr! :-P

Thanks for the heads up, @jrfnl (I was following the discussion). I'm not sure to understand which is the advantage of keeping the old "organisation" name (non-matching the real one). But we are ok, will keep using it (reverting this).

Ciao :-)

@jrfnl
Copy link

jrfnl commented Dec 7, 2023

I'm not sure to understand which is the advantage of keeping the old "organisation" name (non-matching the real one).

Well, there are two advantages:

  1. It saves 200.000+ projects the task of switching over.
    Just to give you some idea, we changed the organisation name of PHPCompatibility (from wimg to phpcompatibility) 5 years ago and there are still packages which haven't switched over.
  2. It will save me and maintainers of various external standards tons of support requests as the files in vendor/bin only get replaced when the replace directive is found (which would be in the 3.8.0 release) and don't necessarily get replaced when a custom bin directory is used, which could lead to worlds of pain.

@stronk7
Copy link
Member Author

stronk7 commented Dec 8, 2023

Thanks @jrfnl , I'll continue asking @ PHPCSStandards/PHP_CodeSniffer#135 , things are moving so quickly that better share things in the canonical issues and prs.

@stronk7
Copy link
Member Author

stronk7 commented Dec 8, 2023

For the records, this PR has been "reverted". We are back to the squizlabs/php_codesniffer package (that is pointing to the PHPCSStandards/PHP_CodeSniffer repo.

Also, bumped to v3.8.0, just released.

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants