Lock nikic/php-parser v4 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that both phpunit and php-code-coverage have started to accept nikic/php-parser v5, but that's leading to problems with PHP 7.4 runs, that we still support. So, with this commit, we are locking nikic/php-parser v4 Once we officially make moodle-cs to only support php >= 8.0 we can remove this lock. Issue: moodlehq#88
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=========================================
Coverage 96.46% 96.46%
Complexity 517 517
=========================================
Files 22 22
Lines 1471 1471
=========================================
Hits 1419 1419
Misses 52 52 ☔ View full report in Codecov by Sentry. |
andrewnicols
approved these changes
Jan 11, 2024
|
Tata! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that both phpunit and php-code-coverage have started to accept nikic/php-parser v5, but that's leading to problems with PHP 7.4 runs, that we still support.
See https://github.com/moodlehq/moodle-cs/actions/runs/7487886902 (that was passing 2-3 weeks ago).
So, with this commit, we are locking nikic/php-parser v4
Once we officially make moodle-cs to only support php >= 8.0 we can remove this lock. Issue: #88