Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitpoddata #291

Merged
merged 4 commits into from
May 7, 2024
Merged

Gitpoddata #291

merged 4 commits into from
May 7, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented May 6, 2024

Added a few improvements to the Gitpod integration:

  • Set gitpod folder permission to install plugins
  • Initialise gitpod with data when DATAFILE variable is given
  • Add adminer to gitpod (only when INSTALLADMINER variable is given)
  • Add parameter to speed gitpod clone. By default, a shallow clone is used when downloading the moodle.git repository. For a full clone, the parameter CLONEALL can be used.

stronk7
stronk7 reviewed May 7, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
stronk7
stronk7 reviewed May 7, 2024
View reviewed changes
.gitpod.yml Show resolved Hide resolved
stronk7
stronk7 reviewed May 7, 2024
View reviewed changes
.gitpod.yml Outdated Show resolved Hide resolved
stronk7
stronk7 approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, I've just left a few, non critical comments/details. Feel free to amend (or ignore) them and proceed to merge yourself.

@sarjona sarjona force-pushed the gitpoddata branch 2 times, most recently from 87f1518 to b682f73 Compare May 7, 2024 10:06
@sarjona
Copy link
Member Author

sarjona commented May 7, 2024

Hi @stronk7!
Thanks a lot for reviewing the patch and raising all these suggestions! I've applied them to improve the Gitpod integration (and before merging them, I've also confirmed everything keeps working OK).
Muchas gracias guapooooooooooo!! :-*

@sarjona sarjona merged commit 835bd01 into moodlehq:main May 7, 2024
127 checks passed
@sarjona sarjona mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stronk7 stronk7 stronk7 approved these changes

Assignees

@sarjona sarjona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarjona @stronk7