Tidying up some codecher issues ...

edit_drawlines_form.php

@@ -74,7 +74,6 @@ public static function file_picker_options(): array {
         return $filepickeroptions;
     }
 
-    #[\Override]
     protected function definition_inner($mform) {
 
         $this->set_current_settings();
@@ -107,7 +106,13 @@ protected function definition_inner($mform) {
         $this->add_interactive_settings(true, true);
     }
 
-    #[\Override]
+    /**
+     * Create the form elements required by one hint.
+     *
+     * @param string $withclearwrong whether this quesiton type uses the 'Clear wrong' option on hints.
+     * @param string $withshownumpartscorrect whether this quesiton type uses the 'Show num parts correct' option on hints.
+     * @return array form field elements for one hint.
+     */
     protected function get_hint_fields($withclearwrong = false, $withshownumpartscorrect = false) {
         $mform = $this->_form;
 
@@ -125,7 +130,6 @@ protected function get_hint_fields($withclearwrong = false, $withshownumpartscor
         return [$repeated, $repeatedoptions];
     }
 
-    #[\Override]
     public function data_preprocessing($question) {
         $question = parent::data_preprocessing($question);
         $question = $this->data_preprocessing_options($question);
@@ -212,7 +216,6 @@ protected function data_preprocessing_hints($question, $withclearwrong = false,
         return $question;
     }
 
-    #[\Override]
     public function validation($data, $files) {
         $errors = parent::validation($data, $files);
         $bgimagesize = $this->get_image_size_in_draft_area($data['bgimage']);

tests/questiontype_test.php

@@ -32,7 +32,7 @@
  * @package    qtype_drawlines
  * @copyright  2024 The Open University
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- * @covers\qtype_drawlines
+ * @covers     \qtype_drawlines
  */
 class questiontype_test extends \advanced_testcase {
     /** @var qtype_drawlines instance of the question type class to test. */
@@ -46,14 +46,23 @@ protected function tearDown(): void {
         $this->qtype = null;
     }
 
+    /**
+     * @covers \question_type::name
+     */
     public function test_name(): void {
         $this->assertEquals($this->qtype->name(), 'drawlines');
     }
 
+    /**
+     * @covers \question_type::can_analyse_responses
+     */
     public function test_can_analyse_responses(): void {
         $this->assertTrue($this->qtype->can_analyse_responses());
     }
 
+    /**
+     * @covers \qtype_drawlines::make_line
+     */
     public function test_make_line(): void {
         $this->resetAfterTest();
 
@@ -76,6 +85,9 @@ public function test_make_line(): void {
         }
     }
 
+    /**
+     * @covers \qtype_drawlines::get_question_options
+     */
     public function test_get_question_options(): void {
         global $DB;
 
@@ -109,6 +121,9 @@ public function test_get_question_options(): void {
         };
     }
 
+    /**
+     * @covers \qtype_drawlines::save_lines
+     */
     public function test_save_lines(): void {
         global $DB;