Pre release chores (#2599)

* use moonbeamfoundation registry for RC images
* remove legacy tasks from the client release checklist
* update tools readme with a deprecation notice
* add the ability to set the profile for benchmarking

.github/workflows/publish-binary.yml

@@ -167,7 +167,7 @@ jobs:
           password: ${{ secrets.MBF_DOCKERHUB_PASSWORD }}
           registry: index.docker.io
       - run: |
-          DOCKER_IMAGE=purestake/moonbeam
+          DOCKER_IMAGE=moonbeamfoundation/moonbeam
           COMMIT=`git rev-list -n 1 '${{ github.event.inputs.to }}'`
           SHA=sha-${COMMIT::8}
           TAG="${{ github.event.inputs.to }}-rc"

scripts/run-benches-for-runtime.sh

@@ -6,20 +6,21 @@
 
 runtime="${1:-moonbase}"
 output="common"
+profile="production"
 
-echo "[+] Compiling benchmarks with production profile... (this will take a while)"
-cargo build --profile=production --locked --features=runtime-benchmarks
+echo "[+] Compiling benchmarks with $profile profile... (this will take a while)"
+cargo build --profile=$profile --locked --features=runtime-benchmarks
 
 # Load all pallet names in an array.
 PALLETS=($(
-  ./target/release/moonbeam benchmark pallet --list --chain="${runtime}-dev" |\
+  ./target/${profile}/moonbeam benchmark pallet --list --chain="${runtime}-dev" |\
     tail -n+2 |\
     cut -d',' -f1 |\
     sort |\
     uniq
 ))
 
-echo "[+] Benchmarking ${#PALLETS[@]} pallets for runtime $runtime"
+echo "[+] Benchmarking ${#PALLETS[@]} pallets for runtime $runtime with $profile profile"
 
 # Define the error file.
 ERR_FILE="benchmarking_errors.txt"
@@ -37,7 +38,7 @@ for PALLET in "${PALLETS[@]}"; do
   fi
 
   OUTPUT=$(
-    ./target/release/moonbeam benchmark pallet \
+    ./target/${profile}/moonbeam benchmark pallet \
     --chain="${runtime}-dev" \
     --steps=50 \
     --repeat=20 \

tools/README.md

@@ -1,9 +1,11 @@
 # Tools
 
+> :warning: These instructions are deprecated and will be removed/replaced in a future release :warning:
+
 ## Launching complete network
 
 Based on [polkadot-launch](https://github.com/paritytech/polkadot-launch), the tool to launch
-multiple relay and parachain nodes, the script [launch.ts](./launch.ts) allows to start a complete
+multiple relay and parachain nodes, the script `launch.ts` allows to start a complete
 network based on the different version of the runtimes
 
 As the moonbeam and relay runtimes evolved, more configurations will be added to the script.
@@ -27,7 +29,7 @@ npm run launch -- --parachain moonbase-0.18.1
 ```
 
 The launch script accepts a preconfigured network (default is "local", see further).
-Those are listed directly inside [launch.ts](./launch.ts). Ex:
+Those are listed directly inside `launch.ts`. Ex:
 
 ```
 "moonriver-genesis": {
@@ -39,7 +41,7 @@ Those are listed directly inside [launch.ts](./launch.ts). Ex:
 
 - "moonriver-genesis" is the name of the configuration
 - "relay" is the name of the configured relay
-  (see relay preconfigured network in [launch.ts](./launch.ts))
+  (see relay preconfigured network in `launch.ts`)
 - "chain" is the chain (including which runtime) to use.
 - "docker" is from which docker image to take the binary matching this version
 

tools/github/print-client-release-issue.ts

@@ -60,7 +60,6 @@ Publish Docker with ${newVersion} and master.
 - [ ] To be manually edited (add pending PRs)
 
 ## Pre-Release
-- [ ] Create a PR that update the launch.ts configuration (to add client conf for this version).
 - [ ] Get that PR approved and merged.
 - [ ] Re-run all extrinsics/hooks benchmarks.
 - [ ] Test downgrade to previous client version (manual test)