Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deque): add @deque.iter2() and @deque.copy() #1354

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Dec 23, 2024

Disclaimer: The coverage improving part of this PR was generated by an LLM agent as part of an experiment.

Summary

New methods added:

  • deque/deque.mbt: Implemented the copy method, which creates a new copy of the deque.
  • deque/deque.mbt: Added the iter2 method, which iterates over the deque with index and element pairs.
  • deque/deque.mbti: Updated the impl T block to include the copy and iter2 methods.

Optimizations:

  • deque/deque.mbt: Applied iter2's implementation method to the existing iter.

Coverage

coverage of `deque/deque.mbt`: 87.4% -> 93.7%

@coveralls
Copy link
Collaborator

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 4296

Details

  • 14 of 19 (73.68%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 81.254%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deque/deque.mbt 14 19 73.68%
Totals Coverage Status
Change from base Build 4295: 0.06%
Covered Lines: 4625
Relevant Lines: 5692

💛 - Coveralls

@rami3l rami3l changed the title feat(deque): add @deque.copy() feat(deque): add @deque.iter2() and @deque.copy() Dec 23, 2024
@bobzhang bobzhang merged commit 86d7a26 into moonbitlang:main Dec 24, 2024
13 checks passed
@rami3l rami3l deleted the feat/deque-copy branch December 24, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants