Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(array,list): use assert_false instead if in test #26

Closed
wants to merge 30 commits into from
Closed

refactor(array,list): use assert_false instead if in test #26

wants to merge 30 commits into from

Conversation

Lampese
Copy link
Collaborator

@Lampese Lampese commented Mar 9, 2024

No description provided.

@Lampese
Copy link
Collaborator Author

Lampese commented Mar 9, 2024

In order to facilitate the merging of #27, I have submitted an additional formatted commit for this pull request. If it passes, please try to use a squash merge.

@Lampese Lampese mentioned this pull request Mar 9, 2024
@bobzhang
Copy link
Contributor

can you do a rebase?

@Lampese
Copy link
Collaborator Author

Lampese commented Mar 11, 2024

can you do a rebase?

yeah I did it.

@Lampese
Copy link
Collaborator Author

Lampese commented Mar 12, 2024

I'm sorry for the error I encountered during rebase. As the test was written for array, why not add the change to #29.

@Lampese Lampese closed this Mar 12, 2024
@Lampese Lampese deleted the refactor-test-use-assertion branch March 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants