Bigint #305

jialunzhang-psu · 2024-04-22T16:05:20Z

No description provided.

coderabbitai · 2024-04-22T16:05:25Z

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-04-27T00:41:42Z

Codecov Report

Attention: Patch coverage is 93.79310% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 88.77%. Comparing base (9d2e40e) to head (ebc85ed).

Files	Patch %	Lines
bigint/bigint.mbt	93.61%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   88.55%   88.77%   +0.21%     
==========================================
  Files          93       95       +2     
  Lines        3409     3554     +145     
==========================================
+ Hits         3019     3155     +136     
- Misses        390      399       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bobzhang

looks good to me in general.
It would be interesting to see the performance compared with implementation using externref bindings through V8

bobzhang · 2024-05-02T02:20:36Z

bigint/bigint.mbti

+fn from_int64(Int64) -> BigInt
+
+fn make_zero() -> BigInt
+


TODO: we will add literal syntax support, e.g, 0n

bobzhang · 2024-05-02T02:21:22Z

bigint/bigint.mbti

+}
+
+type Sign
+impl Sign {


Should this type be publicly exposed?

bobzhang · 2024-05-02T02:22:12Z

bigint/bigint.mbti

+impl BigInt {
+  compare(Self, Self) -> Int
+  debug_write(Self, Buffer) -> Unit
+  deep_clone(Self) -> Self


when deep_clone is needed given BigInt is pure?

bobzhang · 2024-05-02T02:24:07Z

bigint/bigint.mbti

+  op_mul(Self, Self) -> Self
+  op_neg(Self) -> Self
+  op_sub(Self, Self) -> Self
+  to_decimal_string(Self) -> String


should be called to_string directly?

Later we might have to_hex_string, etc. But given that decimal is the most common case, we can name it just to_string.

jialunzhang-psu force-pushed the bigint branch 2 times, most recently from 4828660 to 8dd16b7 Compare April 29, 2024 18:17

jialunzhang-psu added 14 commits May 1, 2024 09:05

init

a7e138b

cp

ccccac7

add to_decimal_string

e99f476

add lsl

e672427

add lsr

a7ead88

add grade_school_div

fe4d160

add single digit case for div

c4e2b23

add from_decimal_string

70b9fbc

Streamline dependency

c6c0e53

fix len

063942a

coverage

4cea684

fix neg div

8f6e39d

coverage

9aadf5b

coverage

3a89c21

jialunzhang-psu force-pushed the bigint branch from 3954e30 to 3a89c21 Compare May 1, 2024 13:05

jialunzhang-psu added 3 commits May 1, 2024 10:53

add karatsuba_mul

25b40f4

coverage

4eb714c

README

ab9923f

jialunzhang-psu marked this pull request as ready for review May 1, 2024 16:19

jialunzhang-psu requested a review from bobzhang May 1, 2024 16:19

bobzhang reviewed May 2, 2024

View reviewed changes

jialunzhang-psu added 2 commits May 1, 2024 22:34

fix visibility

9a23d2e

change to_decimal_string to to_string

ebc85ed

bobzhang merged commit c6daac1 into moonbitlang:main May 2, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigint #305

Bigint #305

jialunzhang-psu commented Apr 22, 2024

coderabbitai bot commented Apr 22, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Apr 27, 2024 •

edited

Loading

bobzhang left a comment

bobzhang May 2, 2024

jialunzhang-psu May 2, 2024

bobzhang May 2, 2024

jialunzhang-psu May 2, 2024

bobzhang May 2, 2024

jialunzhang-psu May 2, 2024

bobzhang May 2, 2024

jialunzhang-psu May 2, 2024

Bigint #305

Bigint #305

Conversation

jialunzhang-psu commented Apr 22, 2024

coderabbitai bot commented Apr 22, 2024

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Apr 27, 2024 • edited Loading

Codecov Report

bobzhang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 27, 2024 •

edited

Loading