Add a list-based stack implementation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason why cla-check failed is that before the first commit, I failed to authorize github due to network problems. Now it has been successful:
|
You could update your branch(for example submit a new commit or merge main branch) to refersh the check. |
|
Did you click the agree button after logging in? @muqiuhan |
Thank you for your reply. After logging in again, cla-check has now passed. |
Yoorkin
requested changes
Mar 11, 2024
Yoorkin
requested changes
Mar 12, 2024
Yoorkin
approved these changes
Mar 13, 2024
|
LGTM, I will do a rebase before merging. |
move the forall and equal implementations from the stack module to the list module remove redundant functions in stack module Remove function 'forall' in the list module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I implemented a Stack based on the existing List in the standard library.